linux-kernel - Re: [PATCH] staging: iio: isl29028: add isl29030 support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170428161716.GA3075@607924cbbc93>
Date:   Fri, 28 Apr 2017 12:17:16 -0400
From:   Brian Masney <masneyb@...tation.org>
To:     Sebastian Reichel <sebastian.reichel@...labora.co.uk>
Cc:     Sebastian Reichel <sre@...nel.org>,
        Jonathan Cameron <jic23@...nel.org>,
        Hartmut Knaack <knaack.h@....de>,
        Lars-Peter Clausen <lars@...afoo.de>,
        Peter Meerwald-Stadler <pmeerw@...erw.net>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-iio@...r.kernel.org, devel@...verdev.osuosl.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: iio: isl29028: add isl29030 support

On Fri, Apr 28, 2017 at 05:55:58PM +0200, Sebastian Reichel wrote:
> isl29030 is basically the same chip. The only difference
> is the chip's first pin. For isl29028 its named ADDR0 and
> can be used to change the chip's i2c address. For isl29030
> on the other hand that pin is named Ials and is an analog
> current output proportional to ALS/IR. This change is
> irrelevant for the Linux driver.
> 
> This has been tested on Motorola Droid 4.
> 
> Signed-off-by: Sebastian Reichel <sebastian.reichel@...labora.co.uk>
> ---
>  Documentation/devicetree/bindings/i2c/trivial-devices.txt | 1 +
>  drivers/staging/iio/light/isl29028.c                      | 6 ++++++
>  2 files changed, 7 insertions(+)

Hi Sebastian,

I moved this driver out of the staging directory earlier this week.
You'll need to base your patch off of IIO testing:

https://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git/log/?h=testing

Your patch should apply cleanly once you update the file path.

Brian