linux-kernel - Re: [PATCH v2 pci] PCI/MSI: pci-xgene-msi: Enable MSI support in ACPI boot for X-Gene v1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3167d9b9-e8e5-d6bf-1b82-3d19f218bad6@jonmasters.org>
Date:   Fri, 28 Apr 2017 12:36:48 -0400
From:   Jon Masters <jcm@...masters.org>
To:     Khuong Dinh <kdinh@....com>, lorenzo.pieralisi@....com,
        marc.zyngier@....com, msalter@...hat.com, bhelgaas@...gle.com,
        linux-pci@...r.kernel.org
Cc:     patches@....com, linux-kernel@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, rjw@...ysocki.net,
        Duc Dang <dhdang@....com>, Jon Masters <jcm@...hat.com>
Subject: Re: [PATCH v2 pci] PCI/MSI: pci-xgene-msi: Enable MSI support in ACPI
 boot for X-Gene v1

On 04/28/2017 01:11 AM, Jon Masters wrote:
> On 04/27/2017 08:54 PM, Khuong Dinh wrote:
>> From: Khuong Dinh <kdinh@....com>
>>
>> This patch makes pci-xgene-msi driver ACPI-aware and provides
>> MSI capability for X-Gene v1 PCIe controllers in ACPI boot mode.
>>
>> Signed-off-by: Khuong Dinh <kdinh@....com>
>> Signed-off-by: Duc Dang <dhdang@....com>
>> Acked-by: Marc Zyngier <marc.zyngier@....com>
> 
> Thanks. Currently testing. Will review and followup shortly.

Attaching boot logs before and after. I tested with an Intel e1000.
Before the patch I get fallback interrupts. Afterward, I get X-Gene MSI
interrupts working. Please followup with answers to Marc's question
about how you propose to guarantee boottime ordering of binding.

I urgently require that AppliedMicro complete upstreaming of this. It
should have been upstream a year ago. You're not the only ones with
patches like this left around - I'm coming for everyone else, too.

Tested-by: Jon Masters <jcm@...masters.org>


View attachment "dmesg_4.11.0-rc8.xgene_msix1+_nomsi.txt" of type "text/plain" (39241 bytes)

View attachment "dmesg_4.11.0-rc8.xgene_msix2+_msi.txt" of type "text/plain" (39011 bytes)