linux-kernel - Re: [PATCH] Enabled pstore write for powerpc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <8737ctqlw1.fsf@concordia.ellerman.id.au>
Date:   Fri, 28 Apr 2017 12:57:50 +1000
From:   Michael Ellerman <mpe@...erman.id.au>
To:     Kees Cook <keescook@...omium.org>,
        Ankit Kumar <ankit@...ux.vnet.ibm.com>
Cc:     Anton Vorontsov <anton@...msg.org>,
        Colin Cross <ccross@...roid.com>,
        Tony Luck <tony.luck@...el.com>,
        Pan Xinhui <xinhui.pan@...ux.vnet.ibm.com>,
        "benh\@kernel.crashing.org" <benh@...nel.crashing.org>,
        Paul Mackerras <paulus@...ba.org>,
        Andrew Donnellan <andrew.donnellan@....ibm.com>,
        Daniel Axtens <dja@...ens.net>,
        Geliang Tang <geliangtang@....com>,
        "linuxppc-dev\@lists.ozlabs.org" <linuxppc-dev@...ts.ozlabs.org>,
        LKML <linux-kernel@...r.kernel.org>,
        "mahesh\@linux.vnet.ibm.com" <mahesh@...ux.vnet.ibm.com>
Subject: Re: [PATCH] Enabled pstore write for powerpc

Kees Cook <keescook@...omium.org> writes:

> On Thu, Apr 27, 2017 at 4:33 AM, Ankit Kumar <ankit@...ux.vnet.ibm.com> wrote:
>> After commit c950fd6f201a kernel registers pstore write based on flag set.
>> Pstore write for powerpc is broken as flags(PSTORE_FLAGS_DMESG) is not set for
>> powerpc architecture. On panic, kernel doesn't write message to
>> /fs/pstore/dmesg*(Entry doesn't gets created at all).
>>
>> This patch enables pstore write for powerpc architecture by setting
>> PSTORE_FLAGS_DMESG flag.
>>
>> Fixes:c950fd6f201a pstore: Split pstore fragile flags
>> Signed-off-by: Ankit Kumar <ankit@...ux.vnet.ibm.com>
>
> Argh, thanks! I thought I'd caught all of these. I'll include this for -stable.

I see you've picked it up, thanks.

cheers