linux-kernel - Re: [PATCH] checkpatch: don't encourage new code to use "networking" style comments

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 28 Apr 2017 15:31:33 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     briannorris@...omium.org
Cc:     joe@...ches.com, apw@...onical.com, linux-kernel@...r.kernel.org,
        herbert@...dor.apana.org.au, mingo@...hat.com,
        akpm@...ux-foundation.org
Subject: Re: [PATCH] checkpatch: don't encourage new code to use
 "networking" style comments

From: Brian Norris <briannorris@...omium.org>
Date: Fri, 28 Apr 2017 12:27:22 -0700

> On Fri, Apr 28, 2017 at 11:24:18AM -0700, Joe Perches wrote:
>> On Fri, 2017-04-28 at 10:55 -0700, Brian Norris wrote:
>> I believe the only person that actually cares about
>> the networking
>> comment style is David Miller.
> 
> Which is why I've CC'd him. If even *he* doesn't care about having
> this warning in checkpatch, then why should anyone else?

Well it potentially saves one round trip for patch submissions.

What I'm not going to do is let people start using different comment
style even for new code in files like net/core/whatever.c after I've
spent nearly two decades getting them to be one way so far.