linux-kernel - Re: [PATCH] [4.11 regression] cpsw/netcp: refine cpts dependency

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20170428.155540.1957134198035319334.davem@davemloft.net>
Date:   Fri, 28 Apr 2017 15:55:40 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     arnd@...db.de
Cc:     grygorii.strashko@...com, nicolas.pitre@...aro.org, w-kwok2@...com,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        tony@...mide.com, linux-omap@...r.kernel.org
Subject: Re: [PATCH] [4.11 regression] cpsw/netcp: refine cpts dependency

From: Arnd Bergmann <arnd@...db.de>
Date: Fri, 28 Apr 2017 17:03:58 +0200

> Tony Lindgren reports a kernel oops that resulted from my compile-time
> fix on the default config. This shows two problems:
> 
> a) configurations that did not already enable PTP_1588_CLOCK will
>    now miss the cpts driver
> 
> b) when cpts support is disabled, the driver crashes. This is a
>    preexisting problem that we did not notice before my patch.
> 
> While the second problem is still being investigated, this modifies
> the dependencies again, getting us back to the original state, with
> another 'select NET_PTP_CLASSIFY' added in to avoid the original
> link error we got, and the 'depends on POSIX_TIMERS' to hide
> the CPTS support when turning it on would be useless.
> 
> Cc: stable@...r.kernel.org # 4.11 needs this
> Fixes: 07fef3623407 ("cpsw/netcp: cpts depends on posix_timers")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

Applied, thanks Arnd.