linux-kernel - Re: [PATCH] net: hso: register netdev later to avoid a race condition

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20170428.161215.1554269734409048791.davem@davemloft.net>
Date:   Fri, 28 Apr 2017 16:12:15 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     andreas@...nade.info
Cc:     joe@...ches.com, gregkh@...uxfoundation.org,
        peter@...leysoftware.com, hns@...delico.com,
        linux-usb@...r.kernel.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: hso: register netdev later to avoid a race
 condition

From: Andreas Kemnade <andreas@...nade.info>
Date: Wed, 26 Apr 2017 19:26:40 +0200

> If the netdev is accessed before the urbs are initialized,
> there will be NULL pointer dereferences. That is avoided by
> registering it when it is fully initialized.
> 
> This case occurs e.g. if dhcpcd is running in the background
> and the device is probed, either after insmod hso or
> when the device appears on the usb bus.
> 
> A backtrace is the following:
 ...
> Reported-by: H. Nikolaus Schaller <hns@...delico.com>
> Signed-off-by: Andreas Kemnade <andreas@...nade.info>

Applied, thanks.