linux-kernel - Re: [PATCH] checkpatch: don't encourage new code to use "networking" style comments

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1493413518.1873.9.camel@perches.com>
Date:   Fri, 28 Apr 2017 14:05:18 -0700
From:   Joe Perches <joe@...ches.com>
To:     Brian Norris <briannorris@...omium.org>,
        David Miller <davem@...emloft.net>
Cc:     apw@...onical.com, linux-kernel@...r.kernel.org,
        herbert@...dor.apana.org.au, mingo@...hat.com,
        akpm@...ux-foundation.org
Subject: Re: [PATCH] checkpatch: don't encourage new code to use
 "networking" style comments

On Fri, 2017-04-28 at 12:51 -0700, Brian Norris wrote:
> FWIW, I don't see this consistently applied at all. Unless my regexes
> are completely wrong [*], it's roughly 50/50 in drivers/net/ and net/,
> and roughly 40/60 (favoring "net" style) in net/core/.

More like 5:1 in net/

$ git grep -E -n "/\*[ \t]*\w" net | grep -v ":1:" | wc -l
30461
$ git grep -E -n "/\*[ \t]*$" net | grep -v ":1:" | wc -l
6061

grep -v ":1:" is to avoid the first line in the file comment