linux-kernel - [PATCH] of: unittest, fix possible use of unitialized variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <1493353873-24246-1-git-send-email-frowand.list@gmail.com>
Date:   Thu, 27 Apr 2017 21:31:13 -0700
From:   frowand.list@...il.com
To:     Rob Herring <robh+dt@...nel.org>, stephen.boyd@...aro.org
Cc:     devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: [PATCH] of: unittest, fix possible use of unitialized variable

From: Frank Rowand <frank.rowand@...y.com>

Fix problem reported in the linux-next build.  last_sibling may be
unitialized in of_unittest() if the device tree is empty.

Signed-off-by: Frank Rowand <frank.rowand@...y.com>
---
 drivers/of/unittest.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/of/unittest.c b/drivers/of/unittest.c
index 12597ff8cfb0..8f14a43f48e5 100644
--- a/drivers/of/unittest.c
+++ b/drivers/of/unittest.c
@@ -2119,7 +2119,7 @@ static int __init overlay_data_add(int onum)
  */
 static __init void of_unittest_overlay_high_level(void)
 {
-	struct device_node *last_sibling;
+	struct device_node *last_sibling = NULL;
 	struct device_node *np;
 	struct device_node *of_symbols;
 	struct device_node *overlay_base_symbols;
-- 
Frank Rowand <frank.rowand@...y.com>