linux-kernel - Re: [PATCH] proc: Fix unbalanced hard link numbers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <877f24vuf3.fsf@xmission.com>
Date:   Fri, 28 Apr 2017 21:06:56 -0500
From:   ebiederm@...ssion.com (Eric W. Biederman)
To:     Takashi Iwai <tiwai@...e.de>
Cc:     Al Viro <viro@...iv.linux.org.uk>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Tristan Ye <tristan.ye@...e.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] proc: Fix unbalanced hard link numbers

Takashi Iwai <tiwai@...e.de> writes:

> proc_create_mount_point() forgot to increase the parent's nlink, and
> it resulted in unbalanced hard link numbers, e.g. /proc/fs shows one
> less than expected.

Applied.  Thanks.

>
> Fixes: eb6d38d5427b ("proc: Allow creating permanently empty directories...")
> Cc: stable@...r.kernel.org
> Reported-by: Tristan Ye <tristan.ye@...e.com>
> Signed-off-by: Takashi Iwai <tiwai@...e.de>
> ---
>  fs/proc/generic.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/fs/proc/generic.c b/fs/proc/generic.c
> index ee27feb34cf4..9425c0d97262 100644
> --- a/fs/proc/generic.c
> +++ b/fs/proc/generic.c
> @@ -472,6 +472,7 @@ struct proc_dir_entry *proc_create_mount_point(const char *name)
>  		ent->data = NULL;
>  		ent->proc_fops = NULL;
>  		ent->proc_iops = NULL;
> +		parent->nlink++;
>  		if (proc_register(parent, ent) < 0) {
>  			kfree(ent);
>  			parent->nlink--;