linux-kernel - Re: [PATCH v1] selftests: Make test_harness.h more generally available

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAGXu5j+ShwrMObKSfQZbNgqqaniPTjmbXGLMOzGO2M_Twfp=1Q@mail.gmail.com>
Date:   Sun, 30 Apr 2017 10:39:05 -0700
From:   Kees Cook <keescook@...omium.org>
To:     Mickaël Salaün <mic@...ikod.net>,
        Shuah Khan <shuah@...nel.org>
Cc:     LKML <linux-kernel@...r.kernel.org>,
        Andy Lutomirski <luto@...capital.net>,
        Will Drewry <wad@...omium.org>, linux-kselftest@...r.kernel.org
Subject: Re: [PATCH v1] selftests: Make test_harness.h more generally available

On Sun, Apr 30, 2017 at 5:26 AM, Mickaël Salaün <mic@...ikod.net> wrote:
> The seccomp/test_harness.h file contains useful helpers to build tests.
> Moving it to the selftest directory should benefit to other test
> components.

Unless Shuah thinks this should live in a new include/ directory, this
looks fine to me.

Acked-by: Kees Cook <keescook@...omium.org>

Thanks!

-Kees

>
> Signed-off-by: Mickaël Salaün <mic@...ikod.net>
> Cc: Andy Lutomirski <luto@...capital.net>
> Cc: Kees Cook <keescook@...omium.org>
> Cc: Shuah Khan <shuah@...nel.org>
> Cc: Will Drewry <wad@...omium.org>
> Link: https://lkml.kernel.org/r/CAGXu5j+8CVz8vL51DRYXqOY=xc3zuKFf=PTENe88XYHzFYidUQ@mail.gmail.com
> ---
>  tools/testing/selftests/seccomp/seccomp_bpf.c        | 2 +-
>  tools/testing/selftests/{seccomp => }/test_harness.h | 0
>  2 files changed, 1 insertion(+), 1 deletion(-)
>  rename tools/testing/selftests/{seccomp => }/test_harness.h (100%)
>
> diff --git a/tools/testing/selftests/seccomp/seccomp_bpf.c b/tools/testing/selftests/seccomp/seccomp_bpf.c
> index 03f1fa495d74..d7095ff58e72 100644
> --- a/tools/testing/selftests/seccomp/seccomp_bpf.c
> +++ b/tools/testing/selftests/seccomp/seccomp_bpf.c
> @@ -37,7 +37,7 @@
>  #include <unistd.h>
>  #include <sys/syscall.h>
>
> -#include "test_harness.h"
> +#include "../test_harness.h"
>
>  #ifndef PR_SET_PTRACER
>  # define PR_SET_PTRACER 0x59616d61
> diff --git a/tools/testing/selftests/seccomp/test_harness.h b/tools/testing/selftests/test_harness.h
> similarity index 100%
> rename from tools/testing/selftests/seccomp/test_harness.h
> rename to tools/testing/selftests/test_harness.h
> --
> 2.11.0
>



-- 
Kees Cook
Pixel Security