linux-kernel - Re: [PATCH v6 1/2] tcmu: Add dynamic growing data area featuresupport

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5f6a28f7-62ab-1096-625c-c42db78af99d@cmss.chinamobile.com>
Date:   Sun, 30 Apr 2017 18:22:51 +0800
From:   Xiubo Li <lixiubo@...s.chinamobile.com>
To:     Mike Christie <mchristi@...hat.com>, nab@...ux-iscsi.org
Cc:     agrover@...hat.com, iliastsi@...ikto.com, namei.unix@...il.com,
        sheng@...ker.org, linux-scsi@...r.kernel.org,
        target-devel@...r.kernel.org, linux-kernel@...r.kernel.org,
        Jianfei Hu <hujianfei@...s.chinamobile.com>
Subject: Re: [PATCH v6 1/2] tcmu: Add dynamic growing data area featuresupport

On 2017年04月30日 13:48, Mike Christie wrote:
> On 04/26/2017 01:25 AM, lixiubo@...s.chinamobile.com wrote:
>>   	for_each_sg(data_sg, sg, data_nents, i) {
>> @@ -275,22 +371,26 @@ static void alloc_and_scatter_data_area(struct tcmu_dev *udev,
>>   		from = kmap_atomic(sg_page(sg)) + sg->offset;
>>   		while (sg_remaining > 0) {
>>   			if (block_remaining == 0) {
>> -				block = find_first_zero_bit(udev->data_bitmap,
>> -						DATA_BLOCK_BITS);
>>   				block_remaining = DATA_BLOCK_SIZE;
>> -				set_bit(block, udev->data_bitmap);
>> +				dbi = tcmu_get_empty_block(udev, &to);
>> +				if (dbi < 0)
>
> I know it you fixed the missing kunmap_atomic here and missing unlock in
> tcmu_queue_cmd_ring in the next patch, but I think normally people
> prefer that one patch does not add a bug, then the next patch fixes it.
Do you mean the following kmap_atomic() ?

from = kmap_atomic(sg_page(sg)) + sg->offset;

In this patch there has no new kmap/kunmap introduced. This is the old 
code and
the kunmap is at the end of aasda().

This as the initial patch, the memory is from slab cache now. But since 
the second
patch followed will covert to use memory page from the buddy directly.


Thanks,

BRs
Xiubo Li