linux-kernel - Re: [PATCH 2/2 v2] char: misc: use octal permissions for the proc entry

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHp75VfPyzVt+DQP2SYcYT4VERuM_e-KYX66yiH4jbFbiONKoQ@mail.gmail.com>
Date:   Sun, 30 Apr 2017 15:52:03 +0300
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Martin Kaiser <martin@...ser.cx>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/2 v2] char: misc: use octal permissions for the proc entry

On Sat, Apr 29, 2017 at 10:05 AM, Martin Kaiser <martin@...ser.cx> wrote:
> Thus wrote Andy Shevchenko (andy.shevchenko@...il.com):
>> On Tue, Apr 18, 2017 at 12:11 PM, Martin Kaiser <martin@...ser.cx> wrote:

>> Aren't 0 and 0444 different by meaning?
>
> my undestanding is that proc_create() calls proc_create_data(), where
>
>    if ((mode & S_IALLUGO) == 0)
>       mode |= S_IRUGO;
>
> sets mode to 0444 when it was 0.

Ah, okay. Fair enough.

-- 
With Best Regards,
Andy Shevchenko