linux-kernel - MIPS: Lantiq: Completion of error handling around clkdev_add

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <b27c5b95-747b-e83a-84e8-01fd7a1ae04e@users.sourceforge.net>
Date:   Sun, 30 Apr 2017 16:20:33 +0200
From:   SF Markus Elfring <elfring@...rs.sourceforge.net>
To:     linux-mips@...ux-mips.org, Arnd Bergmann <arnd@...db.de>,
        Felix Fietkau <nbd@....name>,
        Hauke Mehrtens <hauke@...ke-m.de>,
        James Hogan <james.hogan@...tec.com>,
        John Crispin <john@...ozen.org>,
        Ralf Bächle <ralf@...ux-mips.org>
Cc:     LKML <linux-kernel@...r.kernel.org>,
        kernel-janitors@...r.kernel.org, Pan Bian <bianpan2016@....com>
Subject: MIPS: Lantiq: Completion of error handling around clkdev_add_clkout()

Hello,

I have noticed by execution of another script for the semantic patch language
(Coccinelle software) that the function “clkdev_add_clkout” does not contain
null pointer checks after calls of the function “kzalloc”.
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/arch/mips/lantiq/xway/sysctrl.c?h=v4.10#n403

How do you think about to add corresponding checks and adjust the function
return type there?

Regards,
Markus