linux-kernel - Re: [PATCH RESEND 1/3 v4] drivers:power:twl4030-charger: don't check if battery is present

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170501112631.2kz4bbga4hfznhsz@earth>
Date:   Mon, 1 May 2017 13:26:31 +0200
From:   Sebastian Reichel <sebastian.reichel@...labora.co.uk>
To:     "H. Nikolaus Schaller" <hns@...delico.com>
Cc:     Dmitry Eremin-Solenikov <dbaryshkov@...il.com>,
        David Woodhouse <dwmw2@...radead.org>,
        Grazvydas Ignotas <notasas@...il.com>,
        Andreas Kemnade <andreas@...nade.info>,
        linux-pm@...r.kernel.org, letux-kernel@...nphoenux.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH RESEND 1/3 v4] drivers:power:twl4030-charger: don't check
 if battery is present

Hi,

On Fri, Apr 14, 2017 at 09:29:38PM +0200, H. Nikolaus Schaller wrote:
> We can't assume that the battery is or stays present after probing
> on devices with replaceable battery.
> 
> On some devices (e.g. GTA04 or OpenPanodra) it can be removed
> and even be hot swapped by the user while device continues to operate
> through external AC or USB power (as long as system power consumption
> remains below ca. 500mA as provided by USB). Under certain conditions
> it is possible to boot without battery.
> 
> So it makes no sense to check for this situation during probe and make
> the charger driver (and its status reports) completely non-operational if
> the battery can be inserted later.
> 
> Tested on: GTA04 and OpenPandora.
> 
> Signed-off-by: H. Nikolaus Schaller <hns@...delico.com>

Thanks, queued.

-- Sebastian

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)