linux-kernel - Re: [PATCH v3 1/5] clk: sunxi-ng: Add sun4i/sun7i CCU driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170501160251.rv5uqlq37hfc3ex7@lukather>
Date:   Mon, 1 May 2017 18:02:51 +0200
From:   Maxime Ripard <maxime.ripard@...e-electrons.com>
To:     Priit Laes <plaes@...es.org>
Cc:     linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        devicetree@...r.kernel.org, linux-clk@...r.kernel.org,
        Philipp Zabel <p.zabel@...gutronix.de>,
        Russell King <linux@...linux.org.uk>,
        Chen-Yu Tsai <wens@...e.org>,
        Mark Rutland <mark.rutland@....com>,
        Rob Herring <robh+dt@...nel.org>,
        Stephen Boyd <sboyd@...eaurora.org>,
        Michael Turquette <mturquette@...libre.com>,
        linux-sunxi@...glegroups.com
Subject: Re: [PATCH v3 1/5] clk: sunxi-ng: Add sun4i/sun7i CCU driver

Hi Priit,

Almost good, thanks!

On Wed, Apr 26, 2017 at 10:32:21PM +0300, Priit Laes wrote:
> +/* TODO: GPS CLK 0x0d0 */

You should still create a define in the header for this one.

> +/* Following only exist on sun7i-a20 */
> +#define CLK_MBUS		165
> +#define CLK_HDMI1_SLOW		166
> +#define CLK_HDMI1		167
> +#define CLK_OUT_A		168
> +#define CLK_OUT_B		169

Wouldn't it be better to simply create a new A20-only header that
would include the A10's and add the A20 specific clocks on top?

Thanks!
Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

Download attachment "signature.asc" of type "application/pgp-signature" (802 bytes)