linux-kernel - Re: [PATCH] libnvdimm: rework region badblocks clearing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAPcyv4hwt8nf5+ADQyj_ahtACZq+if__SqC3dBZTCd==4OWZXA@mail.gmail.com>
Date:   Mon, 1 May 2017 09:16:51 -0700
From:   Dan Williams <dan.j.williams@...el.com>
To:     "Kani, Toshimitsu" <toshi.kani@....com>
Cc:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-nvdimm@...ts.01.org" <linux-nvdimm@...ts.01.org>,
        "Jiang, Dave" <dave.jiang@...el.com>,
        "Verma, Vishal L" <vishal.l.verma@...el.com>
Subject: Re: [PATCH] libnvdimm: rework region badblocks clearing

On Mon, May 1, 2017 at 9:12 AM, Kani, Toshimitsu <toshi.kani@....com> wrote:
> On Mon, 2017-05-01 at 08:52 -0700, Dan Williams wrote:
>> On Mon, May 1, 2017 at 8:43 AM, Dan Williams <dan.j.williams@...el.co
>> m> wrote:
>> > On Mon, May 1, 2017 at 8:34 AM, Kani, Toshimitsu <toshi.kani@....co
>> > m> wrote:
>> > > On Sun, 2017-04-30 at 05:39 -0700, Dan Williams wrote:
>  :
>> > >
>> > > Hi Dan,
>> > >
>> > > I was testing the change with CONFIG_DEBUG_ATOMIC_SLEEP set this
>> > > time, and hit the following BUG with BTT.  This is a separate
>> > > issue (not introduced by this patch), but it shows that we have
>> > > an issue with the DSM call path as well.
>> >
>> > Ah, great find, thanks! We don't see this in the unit tests because
>> > the nfit_test infrastructure takes no sleeping actions in its
>> > simulated DSM path. Outside of converting btt to use sleeping locks
>> > I'm not sure I see a path forward. I wonder how bad the performance
>> > impact of that would be? Perhaps with opportunistic spinning it
>> > won't be so bad, but I don't see another choice.
>>
>> It's worse than that. Part of the performance optimization of BTT I/O
>> was to avoid locking altogether when we could rely on a BTT lane
>> percpu, so that would also need to be removed.
>
> I do not have a good idea either, but I'd rather disable this clearing
> in the regular BTT write path than adding sleeping locks to BTT.
> Clearing a bad block in the BTT write path is difficult/challenging
> since it allocates a new block.

Actually, that may make things easier. Can we teach BTT to track error
blocks and clear them before they are reassigned?