lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 1 May 2017 14:44:07 +0800 From: Sean Wang <sean.wang@...iatek.com> To: Linus Walleij <linus.walleij@...aro.org> CC: Rob Herring <robh+dt@...nel.org>, Matthias Brugger <matthias.bgg@...il.com>, John Crispin <john@...ozen.org>, Mark Rutland <mark.rutland@....com>, Russell King <linux@...linux.org.uk>, "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>, "moderated list:ARM/Mediatek SoC support" <linux-mediatek@...ts.infradead.org>, "linux-arm-kernel@...ts.infradead.org" <linux-arm-kernel@...ts.infradead.org>, "linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org> Subject: Re: [PATCH v2 02/30] pinctrl: mediatek: reuse pinctrl driver for mt7623 On Fri, 2017-04-28 at 10:01 +0200, Linus Walleij wrote: > On Wed, Apr 26, 2017 at 11:25 AM, <sean.wang@...iatek.com> wrote: > > > From: Sean Wang <sean.wang@...iatek.com> > > > > mt7623 pinctrl driver can be compatible with mt2701 one, > > so the patch reuses the driver and deletes those redundant > > ones. > > > > Cc: John Crispin <john@...ozen.org> > > Signed-off-by: Sean Wang <sean.wang@...iatek.com> > > Partly correct. > > > "mediatek,mt6397-pinctrl", compatible with mt6397 pinctrl. > > - "mediatek,mt7623-pinctrl", compatible with mt7623 pinctrl. > > NO don't do this. > > "compatible" means exactly this: this hardware is compatible with > this driver. That is why we have it! > > So instead of mt7623 pretending to be mt2701, let the mt2701 driver > list that it is compatible with mt7623, simple. > > So patch pinctrl-mt2701.c mt2701_pctrl_match[] instead. > Hi Linus, really appreciate your clear guidance and reviewing on this I will fix it up in the next version Sean > Yours, > Linus Walleij
Powered by blists - more mailing lists