linux-kernel - Re: [PATCH 1/1] staging: rtl8192u: Convert u4bAcParam back to little-endian after construction

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 1 May 2017 23:53:39 +0100
From:   Tuomo <tuomo.rinne@...il.com>
To:     Greg KH <gregkh@...uxfoundation.org>
Cc:     devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/1] staging: rtl8192u: Convert u4bAcParam back to
 little-endian after construction

On Mon, May 01, 2017 at 02:34:36PM -0700, Greg KH wrote:
> On Mon, May 01, 2017 at 06:11:58PM +0100, Tuomo Rinne wrote:
> > 
> > The commit 9304b5b0d4fe ("staging: rtl8192u: Fix sparse warnings in r8192U_dm.c")
> > adds casting of le16 from cpu endianness.
> > This patch converts the u4bAcParam parameter back to little-endian after
> > it has been constructed.
> > 
> > Signed-off-by: Tuomo Rinne <tuomo.rinne@...il.com>
> > ---
> >  drivers/staging/rtl8192u/r8192U_dm.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/staging/rtl8192u/r8192U_dm.c b/drivers/staging/rtl8192u/r8192U_dm.c
> > index 283dda4..fd8225c 100644
> > --- a/drivers/staging/rtl8192u/r8192U_dm.c
> > +++ b/drivers/staging/rtl8192u/r8192U_dm.c
> > @@ -2321,10 +2321,10 @@ static void dm_check_edca_turbo(
> >  			u1bAIFS  <<= AC_PARAM_AIFS_OFFSET;
> >  
> >  			u4bAcParam = op_limit | cw_max | cw_min | u1bAIFS;
> > +			cpu_to_le32s(u4bAcParam);
> >  
> >  			write_nic_dword(dev, EDCAPARA_BE, u4bAcParam);
> >  
> > -
> 
> Why is this line removed?
> 
> thanks,
> 
> greg k-h

Hi,

I cleaned up the commit and resubmitted the patchset.

Thanks,
Tuomo