linux-kernel - Re: [PATCH v2 3/5] drm/msm: Reuse dma_fence

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 2 May 2017 06:20:25 -0400
From:   Rob Clark <robdclark@...il.com>
To:     Eric Anholt <eric@...olt.net>
Cc:     "dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        linux-arm-msm <linux-arm-msm@...r.kernel.org>,
        freedreno <freedreno@...ts.freedesktop.org>
Subject: Re: [PATCH v2 3/5] drm/msm: Reuse dma_fence_release.

On Wed, Apr 12, 2017 at 3:12 PM, Eric Anholt <eric@...olt.net> wrote:
> If we follow the typical pattern of the base class being the first
> member, we can use the default dma_fence_free function.
>
> Signed-off-by: Eric Anholt <eric@...olt.net>
> Cc: Rob Clark <robdclark@...il.com>
> Cc: linux-arm-msm@...r.kernel.org
> Cc: freedreno@...ts.freedesktop.org

Reviewed-by: Rob Clark <robdclark@...il.com>

(go ahead and push via drm-misc with the rest of the series, if you
haven't already)


> ---
>  drivers/gpu/drm/msm/msm_fence.c | 10 ++--------
>  1 file changed, 2 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/gpu/drm/msm/msm_fence.c b/drivers/gpu/drm/msm/msm_fence.c
> index 3f299c537b77..a2f89bac9c16 100644
> --- a/drivers/gpu/drm/msm/msm_fence.c
> +++ b/drivers/gpu/drm/msm/msm_fence.c
> @@ -99,8 +99,8 @@ void msm_update_fence(struct msm_fence_context *fctx, uint32_t fence)
>  }
>
>  struct msm_fence {
> -       struct msm_fence_context *fctx;
>         struct dma_fence base;
> +       struct msm_fence_context *fctx;
>  };
>
>  static inline struct msm_fence *to_msm_fence(struct dma_fence *fence)
> @@ -130,19 +130,13 @@ static bool msm_fence_signaled(struct dma_fence *fence)
>         return fence_completed(f->fctx, f->base.seqno);
>  }
>
> -static void msm_fence_release(struct dma_fence *fence)
> -{
> -       struct msm_fence *f = to_msm_fence(fence);
> -       kfree_rcu(f, base.rcu);
> -}
> -
>  static const struct dma_fence_ops msm_fence_ops = {
>         .get_driver_name = msm_fence_get_driver_name,
>         .get_timeline_name = msm_fence_get_timeline_name,
>         .enable_signaling = msm_fence_enable_signaling,
>         .signaled = msm_fence_signaled,
>         .wait = dma_fence_default_wait,
> -       .release = msm_fence_release,
> +       .release = dma_fence_free,
>  };
>
>  struct dma_fence *
> --
> 2.11.0
>