linux-kernel - Re: LKML: "Fixes as per checkpatch.pl" patches

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <1493741881.22125.6.camel@perches.com>
Date:   Tue, 02 May 2017 09:18:01 -0700
From:   Joe Perches <joe@...ches.com>
To:     Ali Kaasinen <ali.kaasinen@...il.com>
Cc:     LKML <linux-kernel@...r.kernel.org>
Subject: Re: LKML: "Fixes as per checkpatch.pl" patches

On Tue, 2017-05-02 at 18:08 +0300, Ali Kaasinen wrote:
> Hellooo, presumably contacted the right people.
> 
> I often browse LKML, and patches saying "Fix style issues as reported by 
> checkpatch.pl", and Greg responding "That's really vague, you need to be 
> specific, and only fix one type of thing per patch" seem fairly common 
> these days, e.g.:
> 
> - http://lkml.iu.edu/hypermail/linux/kernel/1704.3/01867.html
> 
> - http://lkml.iu.edu/hypermail/linux/kernel/1705.0/00105.html
> 
> Just wondering, shouldn't checkpatch mention that?

This question should be asked while cc'ing lkml.

What Greg does with patches is up to Greg.

A checkpatch user guide in Documentation could be useful.