lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 2 May 2017 11:52:41 -0700 From: Bjorn Andersson <bjorn.andersson@...aro.org> To: Stanimir Varbanov <stanimir.varbanov@...aro.org> Cc: Sakari Ailus <sakari.ailus@....fi>, Mauro Carvalho Chehab <mchehab@...nel.org>, Hans Verkuil <hverkuil@...all.nl>, Andy Gross <andy.gross@...aro.org>, Stephen Boyd <sboyd@...eaurora.org>, Srinivas Kandagatla <srinivas.kandagatla@...aro.org>, linux-media@...r.kernel.org, linux-kernel@...r.kernel.org, linux-arm-msm@...r.kernel.org Subject: Re: [PATCH v8 05/10] media: venus: adding core part and helper functions On Tue 02 May 01:52 PDT 2017, Stanimir Varbanov wrote: > Hei Sakari, > > On 04/30/2017 01:21 AM, Sakari Ailus wrote: > > Hi, Stan!! > > > > On Fri, Apr 28, 2017 at 12:13:52PM +0300, Stanimir Varbanov wrote: > > ... > >> +int helper_get_bufreq(struct venus_inst *inst, u32 type, > >> + struct hfi_buffer_requirements *req) > >> +{ > >> + u32 ptype = HFI_PROPERTY_CONFIG_BUFFER_REQUIREMENTS; > >> + union hfi_get_property hprop; > >> + int ret, i; > > > > unsigned int i ? It's an array index... > > Thanks for pointing that out, I have to revisit all similar places as > well ... > It's perfectly fine to index an array with an int and you are comparing the index with a integer constant in the loop - so don't clutter the code unnecessarily. Regards, Bjorn
Powered by blists - more mailing lists