linux-kernel - Re: [PATCH] staging: rtl8192u: ieee80211: rtl819x

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <1493772678.22125.10.camel@perches.com>
Date:   Tue, 02 May 2017 17:51:18 -0700
From:   Joe Perches <joe@...ches.com>
To:     Fabrizio Perria <fabrizio.perria@...il.com>,
        gregkh@...uxfoundation.org, robsonde@...il.com, arnd@...db.de,
        devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: rtl8192u: ieee80211: rtl819x_TSProc: Fixed
 coding style issue

On Tue, 2017-05-02 at 20:24 -0400, Fabrizio Perria wrote:
> Fixed checkpatch.pl issue
> ERROR: that open brace { should be on the previous line
[]
> diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c b/drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c
[]
> @@ -338,8 +338,7 @@ bool GetTs(
>  	else
>  	{
>  		// In WMM case: we use 4 TID only
> -		if (!IsACValid(TID))
> -		{
> +		if (!IsACValid(TID)) {
>  			IEEE80211_DEBUG(IEEE80211_DL_ERR, " in %s(), TID(%d) is not valid\n", __func__, TID);
>  			return false;
>  		}

Why fix only one of these?

$ ./scripts/checkpatch.pl --show-types --strict --types=else_after_brace,open_brace,braces --terse \
  -f drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c

drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c:39: ERROR:OPEN_BRACE: that open brace { should be on the previous line
drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c:42: ERROR:OPEN_BRACE: that open brace { should be on the previous line
drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c:48: ERROR:OPEN_BRACE: that open brace { should be on the previous line
drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c:62: ERROR:OPEN_BRACE: that open brace { should be on the previous line
drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c:62: ERROR:ELSE_AFTER_BRACE: else should follow close brace '}'
drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c:70: ERROR:OPEN_BRACE: that open brace { should be on the previous line
drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c:84: ERROR:OPEN_BRACE: that open brace { should be on the previous line
drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c:150: ERROR:OPEN_BRACE: that open brace { should be on the previous line
drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c:175: ERROR:OPEN_BRACE: that open brace { should be on the previous line
drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c:194: ERROR:OPEN_BRACE: that open brace { should be on the previous line
drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c:203: CHECK:BRACES: Blank lines aren't necessary before a close brace '}'
drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c:226: ERROR:OPEN_BRACE: that open brace { should be on the previous line
drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c:228: ERROR:OPEN_BRACE: that open brace { should be on the previous line
drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c:233: ERROR:OPEN_BRACE: that open brace { should be on the previous line
drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c:233: ERROR:ELSE_AFTER_BRACE: else should follow close brace '}'
drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c:239: ERROR:OPEN_BRACE: that open brace { should be on the previous line
drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c:239: ERROR:ELSE_AFTER_BRACE: else should follow close brace '}'
drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c:246: ERROR:OPEN_BRACE: that open brace { should be on the previous line
drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c:246: ERROR:ELSE_AFTER_BRACE: else should follow close brace '}'
drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c:248: ERROR:OPEN_BRACE: that open brace { should be on the previous line
drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c:254: ERROR:OPEN_BRACE: that open brace { should be on the previous line
drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c:254: ERROR:ELSE_AFTER_BRACE: else should follow close brace '}'
drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c:268: ERROR:OPEN_BRACE: that open brace { should be on the previous line
drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c:276: ERROR:OPEN_BRACE: that open brace { should be on the previous line
drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c:282: CHECK:BRACES: Blank lines aren't necessary before a close brace '}'
drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c:287: WARNING:BRACES: braces {} are not necessary for any arm of this statement
drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c:290: ERROR:ELSE_AFTER_BRACE: else should follow close brace '}'
drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c:330: ERROR:OPEN_BRACE: that open brace { should be on the previous line
drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c:338: ERROR:OPEN_BRACE: that open brace { should be on the previous line
drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c:341: ERROR:OPEN_BRACE: that open brace { should be on the previous line
drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c:347: ERROR:OPEN_BRACE: that open brace { should be on the previous line
drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c:376: ERROR:OPEN_BRACE: that open brace { should be on the previous line
drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c:380: ERROR:OPEN_BRACE: that open brace { should be on the previous line
drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c:380: ERROR:ELSE_AFTER_BRACE: else should follow close brace '}'
drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c:386: ERROR:OPEN_BRACE: that open brace { should be on the previous line
drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c:386: ERROR:ELSE_AFTER_BRACE: else should follow close brace '}'
drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c:409: ERROR:OPEN_BRACE: that open brace { should be on the previous line
drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c:413: ERROR:OPEN_BRACE: that open brace { should be on the previous line
drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c:418: ERROR:ELSE_AFTER_BRACE: else should follow close brace '}'
drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c:418: CHECK:BRACES: Unbalanced braces around else statement
drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c:442: ERROR:OPEN_BRACE: that open brace { should be on the previous line
drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c:442: ERROR:ELSE_AFTER_BRACE: else should follow close brace '}'
drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c:460: ERROR:OPEN_BRACE: that open brace { should be on the previous line
drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c:468: ERROR:OPEN_BRACE: that open brace { should be on the previous line
drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c:477: ERROR:OPEN_BRACE: that open brace { should be on the previous line
drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c:482: WARNING:BRACES: braces {} are not necessary for single statement blocks
drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c:494: ERROR:OPEN_BRACE: that open brace { should be on the previous line
drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c:494: ERROR:ELSE_AFTER_BRACE: else should follow close brace '}'
drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c:506: ERROR:OPEN_BRACE: that open brace { should be on the previous line
drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c:508: ERROR:OPEN_BRACE: that open brace { should be on the previous line
drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c:516: ERROR:OPEN_BRACE: that open brace { should be on the previous line
drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c:518: ERROR:OPEN_BRACE: that open brace { should be on the previous line
drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c:527: ERROR:OPEN_BRACE: that open brace { should be on the previous line
drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c:529: ERROR:OPEN_BRACE: that open brace { should be on the previous line
drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c:537: ERROR:OPEN_BRACE: that open brace { should be on the previous line
drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c:539: ERROR:OPEN_BRACE: that open brace { should be on the previous line
drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c:552: ERROR:OPEN_BRACE: that open brace { should be on the previous line
drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c:559: ERROR:OPEN_BRACE: that open brace { should be on the previous line
drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c:566: ERROR:OPEN_BRACE: that open brace { should be on the previous line
drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c:573: ERROR:OPEN_BRACE: that open brace { should be on the previous line
drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c:583: ERROR:OPEN_BRACE: that open brace { should be on the previous line
drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c:586: ERROR:OPEN_BRACE: that open brace { should be on the previous line
drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c:592: ERROR:OPEN_BRACE: that open brace { should be on the previous line
drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c:592: ERROR:ELSE_AFTER_BRACE: else should follow close brace '}'
drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c:598: ERROR:ELSE_AFTER_BRACE: else should follow close brace '}'
total: 60 errors, 2 warnings, 3 checks, 600 lines checked