linux-kernel - Re: [PATCH v2] iio: adc: Add support for TI ADC1x8s102

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <920e159a-d082-3879-5d8b-f407c5df5915@metafoo.de>
Date:   Wed, 3 May 2017 10:49:30 +0200
From:   Lars-Peter Clausen <lars@...afoo.de>
To:     Andy Shevchenko <andy.shevchenko@...il.com>,
        Jan Kiszka <jan.kiszka@...mens.com>
Cc:     Jonathan Cameron <jic23@...nel.org>, Rob Herring <robh@...nel.org>,
        linux-iio@...r.kernel.org,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Sascha Weisenberger <sascha.weisenberger@...mens.com>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Mika Westerberg <mika.westerberg@...ux.intel.com>,
        Peter Meerwald-Stadler <pmeerw@...erw.net>
Subject: Re: [PATCH v2] iio: adc: Add support for TI ADC1x8s102

On 05/03/2017 10:43 AM, Andy Shevchenko wrote:
>>>>>> +               .owner  = THIS_MODULE,
>>>>>
>>>>> This is redundant I'm pretty sure.
>>>>
>>>> Even in 2017, drivers keep being added that carry such assignments. Can
>>>> you explain when it is needed and when not? Otherwise, I will leave it in.
>>>
>>> The above I'm 100% sure is not needed. It's needed only in cases when
>>> framework / device core doesn't do this for ya.
>>>
>>> In the above case IIRC device core does it once for all.
> 
>> Then this is not consistently filtered out in new driver reviews. I can
>> remove it, of course.
> 
> Please, remove.
> 
> I guess many of new drivers just lack of proper review :-(
> 

The kbuild bot will even send automated patches to remove the owner field if
a patch that has the owner field is merged. So definitely remove it.