linux-kernel - RE: [PATCH] staging: unisys: Solve sparse warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CY4PR07MB3176C1CCAB992E16829969F6F0160@CY4PR07MB3176.namprd07.prod.outlook.com>
Date:   Wed, 3 May 2017 15:20:36 +0000
From:   "Kershner, David A" <David.Kershner@...sys.com>
To:     Marcos Paulo de Souza <marcos.souza.org@...il.com>
CC:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        "Sell, Timothy C" <Timothy.Sell@...sys.com>,
        "Binder, David Anthony" <David.Binder@...sys.com>,
        Erik Arfvidson <erik.arfvidson@...sys.com>,
        "Wadgaonkar, Sameer Laxmikant" <Sameer.Wadgaonkar@...sys.com>,
        "Curtin, Alexander Paul" <Alexander.Curtin@...sys.com>,
        *S-Par-Maintainer <SParMaintainer@...sys.com>,
        "devel@...verdev.osuosl.org" <devel@...verdev.osuosl.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] staging: unisys: Solve sparse warning

> -----Original Message-----
> From: Marcos Paulo de Souza [mailto:marcos.souza.org@...il.com]
> Sent: Tuesday, May 2, 2017 11:28 PM
> Cc: Marcos Paulo de Souza <marcos.souza.org@...il.com>; Kershner, David
> A <David.Kershner@...sys.com>; Greg Kroah-Hartman
> <gregkh@...uxfoundation.org>; Sell, Timothy C <Timothy.Sell@...sys.com>;
> Binder, David Anthony <David.Binder@...sys.com>; Erik Arfvidson
> <erik.arfvidson@...sys.com>; Wadgaonkar, Sameer Laxmikant
> <Sameer.Wadgaonkar@...sys.com>; Curtin, Alexander Paul
> <Alexander.Curtin@...sys.com>; *S-Par-Maintainer
> <SParMaintainer@...sys.com>; devel@...verdev.osuosl.org; linux-
> kernel@...r.kernel.org
> Subject: [PATCH] staging: unisys: Solve sparse warning
> 
> The following commit fixes the following sparse report:
> 
> drivers/staging//unisys/visorhba/visorhba_main.c:660:29: warning: cast to
> restricted __le64
> 
> by casting readq (which is unsigned long on x86) to u64, as expected by the
> seq_printf call.
> 
> Signed-off-by: Marcos Paulo de Souza <marcos.souza.org@...il.com>
> ---
>  Just compiled tested on x86_64.
> 
>  drivers/staging/unisys/visorhba/visorhba_main.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/unisys/visorhba/visorhba_main.c
> b/drivers/staging/unisys/visorhba/visorhba_main.c
> index 6997b16..46d33e6 100644
> --- a/drivers/staging/unisys/visorhba/visorhba_main.c
> +++ b/drivers/staging/unisys/visorhba/visorhba_main.c
> @@ -657,7 +657,7 @@ static int info_debugfs_show(struct seq_file *seq,
> void *v)
>  		seq_printf(seq, "phys_flags_addr = 0x%016llx\n",
>  			   phys_flags_addr);
>  		seq_printf(seq, "FeatureFlags = %llu\n",
> -			   (__le64)readq(devdata->flags_addr));
> +			   (u64)readq(devdata->flags_addr));

Acked-by: David Kershner <david.kershner@...sys.com>

>  	}
>  	seq_printf(seq, "acquire_failed_cnt = %llu\n",
>  		   devdata->acquire_failed_cnt);
> --
> 2.9.3