linux-kernel - Re: [PATCH v2 4/5] drm/etnaviv: Reuse dma_fence

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87wp9yylkm.fsf@eliezer.anholt.net>
Date:   Wed, 03 May 2017 09:03:21 -0700
From:   Eric Anholt <eric@...olt.net>
To:     Lucas Stach <l.stach@...gutronix.de>
Cc:     dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org,
        Russell King <linux+etnaviv@...linux.org.uk>,
        Christian Gmeiner <christian.gmeiner@...il.com>,
        etnaviv@...ts.freedesktop.org
Subject: Re: [PATCH v2 4/5] drm/etnaviv: Reuse dma_fence_release.

Lucas Stach <l.stach@...gutronix.de> writes:

> Hi Eric,
>
> Am Mittwoch, den 12.04.2017, 12:12 -0700 schrieb Eric Anholt:
>> If we follow the typical pattern of the base class being the first
>> member, we can use the default dma_fence_free function.
>
> Sorry, I don't like this change.
> While it provides a bit of code simplification, it also bakes the
> implicit assumption into the code that dma_fence is the first struct
> member without any checks to validate this assumption. I would at least
> expect a build bug assert, but then the current bit of code to keep this
> explicit and self-documenting is probably just as good.

Fine with me.  Please make sure you grab patch 2, though.

Download attachment "signature.asc" of type "application/pgp-signature" (833 bytes)