linux-kernel - Re: [PATCH 3/9] bio-integrity: bio_integrity

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87wp9xq60c.fsf@dmlp.sw.ru>
Date:   Wed, 03 May 2017 19:06:43 +0300
From:   Dmitry Monakhov <dmonakhov@...nvz.org>
To:     "Martin K. Petersen" <martin.petersen@...cle.com>
Cc:     linux-kernel@...r.kernel.org, linux-block@...r.kernel.org,
        martin.petersen@...cle.com
Subject: Re: [PATCH 3/9] bio-integrity:  bio_integrity_advance must update integrity seed

"Martin K. Petersen" <martin.petersen@...cle.com> writes:

> Dmitry Monakhov <dmonakhov@...nvz.org> writes:
>
>> SCSI drivers do care about bip_seed so we must update it accordingly.
>
>> +	bip->bip_iter.bi_sector += bytes_done >> 9;
>
> This needs to count protection intervals. Otherwise things will break
> for block sizes different from 512 bytes.
No,
AFAIU: bip->bip_iter.bi_sector is always equals to bio->bi_iter.bi_sector
at least bip_set_seed() and bip_get_seed() relays on that.
Only bip->bip_vec must be advanced in intervals (this behavior not
changed by the patch this patch).
>
> -- 
> Martin K. Petersen	Oracle Linux Engineering