linux-kernel - Re: [PATCH] x86/intel_rdt: Fix two typos in Documentation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 03 May 2017 11:29:33 +0800
From:   "Shen, Xiaochen" <xiaochen.shen@...el.com>
To:     tglx@...utronix.de, linux-kernel@...r.kernel.org, x86@...nel.org
CC:     Fenghua Yu <fenghua.yu@...el.com>
Subject: Re: [PATCH] x86/intel_rdt: Fix two typos in Documentation

Sorry, please ignore this patch.

The first typo in this patch has been already fixed by:
a9cad3d4f046 ("Documentation, x86: Intel Memory bandwidth allocation")

A new patch is submitted to address the other typo left over:
https://lkml.org/lkml/2017/5/2/595

Best regards
Xiaochen Shen


On 2017/4/7 1:09, Xiaochen Shen wrote:
> Both typos are in example 3.
>
> Because cache id 0 is the only cache id, the ";" is redundant in
> "# echo "L3:0=ffc00;" > p0/schemata".
>
> And "C0" in "# echo C0 > p0/cpus" is wrong because it specifies core
> 6-7 instead of wanted core 4-7.
>
> Correct the typos to avoid confusion.
>
> Signed-off-by: Xiaochen Shen <xiaochen.shen@...el.com>
> Signed-off-by: Fenghua Yu <fenghua.yu@...el.com>
> ---
>  Documentation/x86/intel_rdt_ui.txt | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/x86/intel_rdt_ui.txt b/Documentation/x86/intel_rdt_ui.txt
> index 51cf6fa..cd752c1 100644
> --- a/Documentation/x86/intel_rdt_ui.txt
> +++ b/Documentation/x86/intel_rdt_ui.txt
> @@ -206,12 +206,12 @@ Next we make a resource group for our real time cores and give
>  it access to the "top" 50% of the cache on socket 0.
>  
>  # mkdir p0
> -# echo "L3:0=ffc00;" > p0/schemata
> +# echo "L3:0=ffc00" > p0/schemata
>  
>  Finally we move core 4-7 over to the new group and make sure that the
>  kernel and the tasks running there get 50% of the cache.
>  
> -# echo C0 > p0/cpus
> +# echo F0 > p0/cpus
>  
>  4) Locking between applications
>