linux-kernel - Re: [PATCH 2/9] pinctrl: Combine two seq_puts() calls into one call in two functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 3 May 2017 20:47:31 +0300
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     SF Markus Elfring <elfring@...rs.sourceforge.net>
Cc:     "linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
        Linus Walleij <linus.walleij@...aro.org>,
        LKML <linux-kernel@...r.kernel.org>,
        kernel-janitors@...r.kernel.org
Subject: Re: [PATCH 2/9] pinctrl: Combine two seq_puts() calls into one call
 in two functions

On Tue, May 2, 2017 at 12:22 PM, SF Markus Elfring
<elfring@...rs.sourceforge.net> wrote:
> From: Markus Elfring <elfring@...rs.sourceforge.net>
> Date: Mon, 1 May 2017 22:42:13 +0200
>
> Some text was put into a sequence by two separate function calls.
> Print the same data by a single function call instead.

I don't see a benefit here, sorry.
This is slow path in any case (printing is slow). Currently code is
neat, you do it slightly harder to parse.


-- 
With Best Regards,
Andy Shevchenko