linux-kernel - [PATCH 2/2 linux-next] gfs2: remove unused flags parameter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <20170503182808.20305-1-fabf@skynet.be>
Date:   Wed,  3 May 2017 20:28:08 +0200
From:   Fabian Frederick <fabf@...net.be>
To:     Steven Whitehouse <swhiteho@...hat.com>,
        Bob Peterson <rpeterso@...hat.com>
Cc:     cluster-devel@...hat.com, linux-fsdevel@...r.kernel.org,
        linux-kernel@...r.kernel.org, fabf@...net.be
Subject: [PATCH 2/2 linux-next] gfs2: remove unused flags parameter

We already assumed rename flags when calling gfs2_exchange()

Signed-off-by: Fabian Frederick <fabf@...net.be>
---
 fs/gfs2/inode.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/fs/gfs2/inode.c b/fs/gfs2/inode.c
index 9698796..b5858a3 100644
--- a/fs/gfs2/inode.c
+++ b/fs/gfs2/inode.c
@@ -1567,14 +1567,12 @@ static int gfs2_rename(struct inode *odir, struct dentry *odentry,
  * @odentry: The old dentry of the file
  * @ndir: Parent directory of new file name
  * @ndentry: The new dentry of the file
- * @flags: The rename flags
  *
  * Returns: errno
  */
 
 static int gfs2_exchange(struct inode *odir, struct dentry *odentry,
-			 struct inode *ndir, struct dentry *ndentry,
-			 unsigned int flags)
+			 struct inode *ndir, struct dentry *ndentry)
 {
 	struct gfs2_inode *odip = GFS2_I(odir);
 	struct gfs2_inode *ndip = GFS2_I(ndir);
@@ -1710,7 +1708,7 @@ static int gfs2_rename2(struct inode *odir, struct dentry *odentry,
 		return -EINVAL;
 
 	if (flags & RENAME_EXCHANGE)
-		return gfs2_exchange(odir, odentry, ndir, ndentry, flags);
+		return gfs2_exchange(odir, odentry, ndir, ndentry);
 
 	return gfs2_rename(odir, odentry, ndir, ndentry);
 }
-- 
2.9.3