linux-kernel - Re: [uml-user] [PATCH] um: Fix _print

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAFLxGvzZ8eGREEDOoYf1hKGwD9yPWqK-8aKAU64YztvLgPxNgA@mail.gmail.com>
Date:   Wed, 3 May 2017 22:55:30 +0200
From:   Richard Weinberger <richard.weinberger@...il.com>
To:     Richard Weinberger <richard@....at>
Cc:     "user-mode-linux-devel@...ts.sourceforge.net" 
        <user-mode-linux-devel@...ts.sourceforge.net>,
        LKML <linux-kernel@...r.kernel.org>,
        "user-mode-linux-user@...ts.sourceforge.net" 
        <user-mode-linux-user@...ts.sourceforge.net>
Subject: Re: [uml-user] [PATCH] um: Fix _print_addr()

On Sun, Dec 25, 2016 at 11:11 PM, Richard Weinberger <richard@....at> wrote:
> Recent changes to printk() broke UML's stack trace
> output. Kill the root of the problem by using a single
> printk() statement.
>
> Signed-off-by: Richard Weinberger <richard@....at>
> ---
>  arch/um/kernel/sysrq.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/arch/um/kernel/sysrq.c b/arch/um/kernel/sysrq.c
> index aa1b56f5ac68..18eddf677ec6 100644
> --- a/arch/um/kernel/sysrq.c
> +++ b/arch/um/kernel/sysrq.c
> @@ -17,10 +17,8 @@
>
>  static void _print_addr(void *data, unsigned long address, int reliable)
>  {
> -       pr_info(" [<%08lx>]", address);
> -       pr_cont(" %s", reliable ? "" : "? ");
> -       print_symbol("%s", address);
> -       pr_cont("\n");
> +       pr_info(" [<%08lx>] %s%pF\n", address, reliable ? "" : "? ",
> +               (void *)address);
>  }
>
>  static const struct stacktrace_ops stackops = {

Applied.

-- 
Thanks,
//richard