linux-kernel - Re: [PATCH 1/3] ARM: dts: imx6qdl-nitrogen6

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170503221620.k3gf3s7lramlgfyf@piout.net>
Date:   Thu, 4 May 2017 00:16:20 +0200
From:   Alexandre Belloni <alexandre.belloni@...e-electrons.com>
To:     Shawn Guo <shawnguo@...nel.org>
Cc:     Gary Bisson <gary.bisson@...ndarydevices.com>,
        Sascha Hauer <kernel@...gutronix.de>,
        Fabio Estevam <fabio.estevam@....com>,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/3] ARM: dts: imx6qdl-nitrogen6_max: fix rv4162
 compatible

On 03/05/2017 at 16:50:12 +0800, Shawn Guo wrote:
> On Wed, Apr 19, 2017 at 10:22:02PM +0200, Alexandre Belloni wrote:
> > The rv4162 vendor is microcrystal, not ST.
> > 
> > Signed-off-by: Alexandre Belloni <alexandre.belloni@...e-electrons.com>
> > ---
> >  arch/arm/boot/dts/imx6qdl-nitrogen6_max.dtsi | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/arch/arm/boot/dts/imx6qdl-nitrogen6_max.dtsi b/arch/arm/boot/dts/imx6qdl-nitrogen6_max.dtsi
> > index bad3c9f9eeac..b63134e3b51a 100644
> > --- a/arch/arm/boot/dts/imx6qdl-nitrogen6_max.dtsi
> > +++ b/arch/arm/boot/dts/imx6qdl-nitrogen6_max.dtsi
> > @@ -408,7 +408,7 @@
> >  	};
> >  
> >  	rtc: rtc@68 {
> > -		compatible = "st,rv4162";
> > +		compatible = "microcrystal,rv4162";
> 
> The compatible is not documented?
> 

No, it wasn't. Like for many i2c devices, the driver predates DT and
didn't need any specific code to be used from DT. Basically, the i2c
core was using the i2c_device_ids to match the DT compatible string.
This is changing since cabcf4f6be658b2d4bea26dee89d08fdf67d6811.

I'm planning to document all the undocumented ones soon.

> Shawn
> 
> >  		pinctrl-names = "default";
> >  		pinctrl-0 = <&pinctrl_rv4162>;
> >  		reg = <0x68>;
> > -- 
> > 2.11.0
> > 

-- 
Alexandre Belloni, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com