linux-kernel - Re: [PATCHv2 1/2] Input: pwm-vibra: new driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170504003952.GN3780@atomide.com>
Date:   Wed, 3 May 2017 17:39:52 -0700
From:   Tony Lindgren <tony@...mide.com>
To:     Sebastian Reichel <sebastian.reichel@...labora.co.uk>
Cc:     Sebastian Reichel <sre@...nel.org>,
        Dmitry Torokhov <dmitry.torokhov@...il.com>,
        Rob Herring <robh+dt@...nel.org>, linux-input@...r.kernel.org,
        linux-omap@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCHv2 1/2] Input: pwm-vibra: new driver

* Sebastian Reichel <sebastian.reichel@...labora.co.uk> [170503 04:14]:
> Provide a simple driver for PWM controllable vibrators. It
> will be used by Motorola Droid 4.
> 
> Signed-off-by: Sebastian Reichel <sebastian.reichel@...labora.co.uk>
> ---
> Changes since PATCHv1:
>  - move driver removal code to input->close function
>  - mark PM functions __maybe_unused and drop #ifdef CONFIG_PM_SLEEP
>  - remove duplicate NULL check for vibrator in probe function
>  - cancel work in suspend function

I'm getting this if CONFIG_INPUT_FF_MEMLESS is not selected:

ERROR: "input_ff_create_memless" [drivers/input/misc/pwm-vibra.ko] undefined!

Other than that works for me with your test app after
modprobe of pwm-omap-dmtimer and ff_memless:

Tested-by: Tony Lindgren <tony@...mide.com>