linux-kernel - [PATCH 3.12 77/86] md:raid1: fix a dead loop when read from a WriteMostly disk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <243ae123385d94570ad0e42280b1e3feaabc6bc8.1493888632.git.jslaby@suse.cz>
Date:   Thu,  4 May 2017 11:04:42 +0200
From:   Jiri Slaby <jslaby@...e.cz>
To:     stable@...r.kernel.org
Cc:     linux-kernel@...r.kernel.org, Wei Fang <fangwei1@...wei.com>,
        Shaohua Li <shli@...com>, Julia Lawall <julia.lawall@...6.fr>,
        Jiri Slaby <jslaby@...e.cz>
Subject: [PATCH 3.12 77/86] md:raid1: fix a dead loop when read from a WriteMostly disk

From: Wei Fang <fangwei1@...wei.com>

3.12-stable review patch.  If anyone has any objections, please let me know.

===============

commit 816b0acf3deb6d6be5d0519b286fdd4bafade905 upstream.

If first_bad == this_sector when we get the WriteMostly disk
in read_balance(), valid disk will be returned with zero
max_sectors. It'll lead to a dead loop in make_request(), and
OOM will happen because of endless allocation of struct bio.

Since we can't get data from this disk in this case, so
continue for another disk.

Signed-off-by: Wei Fang <fangwei1@...wei.com>
Signed-off-by: Shaohua Li <shli@...com>
Cc: Julia Lawall <julia.lawall@...6.fr>
Signed-off-by: Jiri Slaby <jslaby@...e.cz>
---
 drivers/md/raid1.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/md/raid1.c b/drivers/md/raid1.c
index 479828ad2021..e5f8fd19e47d 100644
--- a/drivers/md/raid1.c
+++ b/drivers/md/raid1.c
@@ -560,7 +560,7 @@ static int read_balance(struct r1conf *conf, struct r1bio *r1_bio, int *max_sect
 			if (best_dist_disk < 0) {
 				if (is_badblock(rdev, this_sector, sectors,
 						&first_bad, &bad_sectors)) {
-					if (first_bad < this_sector)
+					if (first_bad <= this_sector)
 						/* Cannot use this */
 						continue;
 					best_good_sectors = first_bad - this_sector;
-- 
2.12.2