linux-kernel - Re: [PATCH v2 3/7] staging: rtl8723bs: Macros with complex values should be enclosed in parentheses

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1493897445.22420.37.camel@hadess.net>
Date:   Thu, 04 May 2017 13:30:45 +0200
From:   Bastien Nocera <hadess@...ess.net>
To:     Justin Vreeland <justin@...eeland.com>, gregkh@...uxfoundation.org,
        Larry.Finger@...inger.net
Cc:     devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 3/7] staging: rtl8723bs: Macros with complex values
 should be enclosed in parentheses

On Mon, 2017-05-01 at 18:52 -0600, Justin Vreeland wrote:
> Enclosing macros with complex values ensures expression is evaluated
> as
> expected.
> 
> Signed-off-by: Justin Vreeland <justin@...eeland.com>
> ---
> v2:
>   - Added spaces around plus signs
>   - Fixed line over 80 columns
>   - Added commit message
> 
>  drivers/staging/rtl8723bs/hal/odm.h | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/rtl8723bs/hal/odm.h
> b/drivers/staging/rtl8723bs/hal/odm.h
> index 0b3541a91548..87a76bafecb3 100644
> --- a/drivers/staging/rtl8723bs/hal/odm.h
> +++ b/drivers/staging/rtl8723bs/hal/odm.h
> @@ -209,7 +209,10 @@ typedef struct _ODM_RATE_ADAPTIVE {
>  
>  #define AVG_THERMAL_NUM		8
>  #define IQK_Matrix_REG_NUM	8
> -#define IQK_Matrix_Settings_NUM	14+24+21
> /*  Channels_2_4G_NUM + Channels_5G_20M_NUM + Channels_5G */
> +#define IQK_Matrix_Settings_NUM	(14 + 24 + 21)
> /*   Channels_2_4G_NUM
> +						* +
> Channels_5G_20M_NUM
> +						* + Channels_5G
> +						*/

This does line up when applied, right? If so:
Reviewed-by: Bastien Nocera <hadess@...ess.net>