linux-kernel - Re: [PATCH v1 2/2] perf report: Display titles in left frame of annotate browser

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170504131250.GE7891@kernel.org>
Date:   Thu, 4 May 2017 10:12:50 -0300
From:   Arnaldo Carvalho de Melo <acme@...nel.org>
To:     Milian Wolff <milian.wolff@...b.com>
Cc:     Jin Yao <yao.jin@...ux.intel.com>, jolsa@...nel.org,
        peterz@...radead.org, mingo@...hat.com,
        alexander.shishkin@...ux.intel.com, Linux-kernel@...r.kernel.org,
        ak@...ux.intel.com, kan.liang@...el.com, yao.jin@...el.com
Subject: Re: [PATCH v1 2/2] perf report: Display titles in left frame of
 annotate browser

Em Thu, May 04, 2017 at 11:01:48AM +0200, Milian Wolff escreveu:
> On Thursday, May 4, 2017 4:58:15 PM CEST Jin Yao wrote:
> > This patch adds the titles "Percent", "IPC" and "Cycle"
> > on columns.

> > Percnt   IPC Cycle │
> >                    │25  __attribute__((noinline))
> >                    │26  int compute_flag()
> >                    │27  {
> >  22.80  1.20       │      sub    $0x8,%rsp
> >                    │25          int i;
> >                    │
> >                    │27          i = rand() % 2;
> >  22.78  1.20     1 │    → callq  rand@plt

> > The titles are displayed at row 0 of annotate browser if row 0
> > doesn't have values of percent, ipc and cycle.
 
> Functionality wise a really good improvement - thanks! But personally I find 
> the abbreviation of one character (i.e. "Percnt" instead of "Percent") not so 
> nice. If space really is an issue here, use "%"?

Ok, will make it 'Percent' as we have space for that, and will add
Acked-by: Millian, ok?
 
> Also note though that it's unclear what this percentage actually is. I guess 
> it's a sample percentage? Maybe a header should be added that explains these 
> values to newbies. I bet many people won't even know what IPC is either.

Perhaps we could have some help files, then when the user presses 'h'
one of the lines would be:

  h   Report explanation (columns, etc)

?

- Arnaldo