linux-kernel - Re: [PATCH] scsi: qedf: properly update arguments position in function call

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.OSX.2.00.1705041106140.1192@n6024mn968stm1.qlogic.org>
Date:   Thu, 4 May 2017 11:06:40 -0400 (EDT)
From:   Chad Dupuis <chad.dupuis@...ium.com>
To:     "Gustavo A. R. Silva" <garsilva@...eddedor.com>
cc:     QLogic-Storage-Upstream@...ium.com,
        "James E.J. Bottomley" <jejb@...ux.vnet.ibm.com>,
        "Martin K. Petersen" <martin.petersen@...cle.com>,
        linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] scsi: qedf: properly update arguments position in function
 call


On Wed, 3 May 2017, 3:17pm, Gustavo A. R. Silva wrote:

> Properly update the position of the arguments in function call.
> 
> Addresses-Coverity-ID: 1402010
> Signed-off-by: Gustavo A. R. Silva <garsilva@...eddedor.com>
> ---
>  drivers/scsi/qedf/qedf_els.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/scsi/qedf/qedf_els.c b/drivers/scsi/qedf/qedf_els.c
> index 59f3e5c..107ed2b 100644
> --- a/drivers/scsi/qedf/qedf_els.c
> +++ b/drivers/scsi/qedf/qedf_els.c
> @@ -106,7 +106,7 @@ static int qedf_initiate_els(struct qedf_rport *fcport, unsigned int op,
>  	did = fcport->rdata->ids.port_id;
>  	sid = fcport->sid;
>  
> -	__fc_fill_fc_hdr(fc_hdr, FC_RCTL_ELS_REQ, sid, did,
> +	__fc_fill_fc_hdr(fc_hdr, FC_RCTL_ELS_REQ, did, sid,
>  			   FC_TYPE_ELS, FC_FC_FIRST_SEQ | FC_FC_END_SEQ |
>  			   FC_FC_SEQ_INIT, 0);
>  
> 

Thanks.

Acked-by: Chad Dupuis <chad.dupuis@...ium.com>