linux-kernel - Patch "netlink: Allow direct reclaim for fallback allocation" has been added to the 4.4-stable tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 04 May 2017 12:43:33 -0700
From:   <gregkh@...uxfoundation.org>
To:     ross.lagerwall@...rix.com, davem@...emloft.net,
        edumazet@...gle.com, gregkh@...uxfoundation.org,
        linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
        stable@...r.kernel.org
Cc:     <stable@...r.kernel.org>, <stable-commits@...r.kernel.org>
Subject: Patch "netlink: Allow direct reclaim for fallback allocation" has been added to the 4.4-stable tree


This is a note to let you know that I've just added the patch titled

    netlink: Allow direct reclaim for fallback allocation

to the 4.4-stable tree which can be found at:
    http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
     netlink-allow-direct-reclaim-for-fallback-allocation.patch
and it can be found in the queue-4.4 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@...r.kernel.org> know about it.


>From ross.lagerwall@...rix.com  Thu May  4 12:37:51 2017
From: Ross Lagerwall <ross.lagerwall@...rix.com>
Date: Wed, 3 May 2017 09:44:19 +0100
Subject: netlink: Allow direct reclaim for fallback allocation
To: <stable@...r.kernel.org>
Cc: Ross Lagerwall <ross.lagerwall@...rix.com>, "David S. Miller" <davem@...emloft.net>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Eric Dumazet <edumazet@...gle.com>, <netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Message-ID: <1493801059-2828-1-git-send-email-ross.lagerwall@...rix.com>

From: Ross Lagerwall <ross.lagerwall@...rix.com>

The backport of d35c99ff77ec ("netlink: do not enter direct reclaim from
netlink_dump()") to the 4.4 branch (first in 4.4.32) mistakenly removed
direct claim from the initial large allocation _and_ the fallback
allocation which means that allocations can spuriously fail.
Fix the issue by adding back the direct reclaim flag to the fallback
allocation.

Fixes: 6d123f1d396b ("netlink: do not enter direct reclaim from netlink_dump()")
Signed-off-by: Ross Lagerwall <ross.lagerwall@...rix.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
---

Note that this is only for the 4.4 branch as the regression is only in
this branch. Consequently, there is no corresponding upstream commit.

I'm resending this to the linux-stable list since I now understand the
netdev maintainer only handles backports for the last couple of versions
of Linux.

 net/netlink/af_netlink.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/net/netlink/af_netlink.c
+++ b/net/netlink/af_netlink.c
@@ -2107,7 +2107,7 @@ static int netlink_dump(struct sock *sk)
 	if (!skb) {
 		alloc_size = alloc_min_size;
 		skb = netlink_alloc_skb(sk, alloc_size, nlk->portid,
-					(GFP_KERNEL & ~__GFP_DIRECT_RECLAIM));
+					GFP_KERNEL);
 	}
 	if (!skb)
 		goto errout_skb;


Patches currently in stable-queue which might be from ross.lagerwall@...rix.com are

queue-4.4/netlink-allow-direct-reclaim-for-fallback-allocation.patch