linux-kernel - Re: [PATCH] scsi: pmcraid: remove redundant check to see if request

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <79da6ab7-da2c-c1fc-e384-92d68028d091@linux.vnet.ibm.com>
Date:   Thu, 4 May 2017 12:46:46 -0700
From:   Tyrel Datwyler <tyreld@...ux.vnet.ibm.com>
To:     Colin King <colin.king@...onical.com>,
        "James E . J . Bottomley" <jejb@...ux.vnet.ibm.com>,
        "Martin K . Petersen" <martin.petersen@...cle.com>,
        linux-scsi@...r.kernel.org
Cc:     kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] scsi: pmcraid: remove redundant check to see if
 request_size is less than zero

On 05/03/2017 09:29 AM, Colin King wrote:
> From: Colin Ian King <colin.king@...onical.com>
> 
> The 2nd check to see if request_size is less than zero is redundant
> because the first check takes error exit path on this condition. So,
> since it is redundant, remove it.
> 
> Detected by CoverityScan, CID#146149 ("Logically Dead Code")
> 
> Signed-off-by: Colin Ian King <colin.king@...onical.com>

Reviewed-by: Tyrel Datwyler <tyreld@...ux.vnet.ibm.com>