linux-kernel - Re: [PATCH V1 1/1] net: cdc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87fugkfib6.fsf@miraculix.mork.no>
Date:   Thu, 04 May 2017 23:01:01 +0200
From:   Bjørn Mork <bjorn@...k.no>
To:     Jim Baxter <jim_baxter@...tor.com>
Cc:     <linux-usb@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        Oliver Neukum <oliver@...kum.org>
Subject: Re: [PATCH V1 1/1] net: cdc_ncm: Fix TX zero padding

Jim Baxter <jim_baxter@...tor.com> writes:

> The zero padding that is added to NTB's does
> not zero the memory correctly.
> This is because the skb_put modifies the value
> of skb_out->len which results in the memset
> command not setting any memory to zero as
> (ctx->tx_max - skb_out->len) == 0.
>
> I have resolved this by storing the size of
> the memory to be zeroed before the skb_put
> and using this in the memset call.
>
> Signed-off-by: Jim Baxter <jim_baxter@...tor.com>

Ouch! Thanks for finding this.  This should go to the stable queue as
well.

Reviewed-by: Bjørn Mork <bjorn@...k.no>