linux-kernel - Re: [PATCH 1/1] rtc: snvs: fix an incorrect check of return value

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170504225818.fjd47dlpdsi2fax6@piout.net>
Date:   Fri, 5 May 2017 00:58:18 +0200
From:   Alexandre Belloni <alexandre.belloni@...e-electrons.com>
To:     Pan Bian <bianpan2016@....com>
Cc:     Alessandro Zummo <a.zummo@...ertech.it>,
        rtc-linux@...glegroups.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/1] rtc: snvs: fix an incorrect check of return value

On 23/04/2017 at 13:43:24 +0800, Pan Bian wrote:
> Function devm_regmap_init_mmio() returns an ERR_PTR on error. However,
> in function snvs_rtc_probe() its return value is checked against NULL.
> This patch fixes it by checking the return value with IS_ERR().
> 
> Signed-off-by: Pan Bian <bianpan2016@....com>
> ---
>  drivers/rtc/rtc-snvs.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
Applied, thanks.

-- 
Alexandre Belloni, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com