linux-kernel - Re: [PATCH v3 7/8] mm, compaction: restrict async compaction to pageblocks of same migratetype

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <45323114-97d7-f34a-8336-51efff26bc8b@suse.cz>
Date:   Thu, 4 May 2017 08:12:56 +0200
From:   Vlastimil Babka <vbabka@...e.cz>
To:     Joonsoo Kim <iamjoonsoo.kim@....com>
Cc:     Johannes Weiner <hannes@...xchg.org>,
        Andrew Morton <akpm@...ux-foundation.org>,
        linux-kernel@...r.kernel.org, linux-mm@...ck.org,
        Mel Gorman <mgorman@...hsingularity.net>,
        David Rientjes <rientjes@...gle.com>, kernel-team@...com,
        kernel-team@....com
Subject: Re: [PATCH v3 7/8] mm, compaction: restrict async compaction to
 pageblocks of same migratetype

On 04/07/2017 02:38 AM, Joonsoo Kim wrote:
> On Wed, Mar 29, 2017 at 06:06:41PM +0200, Vlastimil Babka wrote:
>> On 03/16/2017 03:14 AM, Joonsoo Kim wrote:
>>> On Tue, Mar 07, 2017 at 02:15:44PM +0100, Vlastimil Babka wrote:
>>>> The migrate scanner in async compaction is currently limited to MIGRATE_MOVABLE
>>>> pageblocks. This is a heuristic intended to reduce latency, based on the
>>>> assumption that non-MOVABLE pageblocks are unlikely to contain movable pages.
>>>>
>>>> However, with the exception of THP's, most high-order allocations are not
>>>> movable. Should the async compaction succeed, this increases the chance that
>>>> the non-MOVABLE allocations will fallback to a MOVABLE pageblock, making the
>>>> long-term fragmentation worse.
>>>
>>> I agree with this idea but have some concerns on this change.
>>>
>>> *ASYNC* compaction is designed for reducing latency and this change
>>> doesn't fit it. If everything works fine, there is a few movable pages
>>> in non-MOVABLE pageblocks as you noted above. Moreover, there is quite
>>> less the number of non-MOVABLE pageblock than MOVABLE one so finding
>>> non-MOVABLE pageblock takes long time. These two factors will increase
>>> the latency of *ASYNC* compaction.
>>
>> Right. I lately started to doubt the whole idea of async compaction (for
>> non-movable allocations). Seems it's one of the compaction heuristics tuned
>> towards the THP usecase. But for non-movable allocations, we just can't have
>> both the low latency and long-term fragmentation avoidance. I see now even my
>> own skip_on_failure mode in isolate_migratepages_block() as a mistake for
>> non-movable allocations.
> 
> Why do you think that skip_on_failure mode is a mistake? I think that
> it would lead to reduce the latency and it fits the goal of async
> compaction.

Yes, but the downside is that compaction will create just the single
high-order page that is requested, while previously it would also
migrate away some more lower-order pages. When compacting for
MIGRATE_UNMOVABLE allocation, we then can't steal extra pages, so next
allocation might pollute a different pageblock. It's not a good tradeoff.

>>
>> Ideally I'd like to make async compaction redundant by kcompactd, and direct
>> compaction would mean a serious situation which should warrant sync compaction.
>> Meanwhile I see several options to modify this patch
>> - async compaction for non-movable allocations will stop doing the
>> skip_on_failure mode, and won't restrict the pageblock at all. patch 8/8 will
>> make sure that also this kind of compaction finishes the whole pageblock
>> - non-movable allocations will skip async compaction completely and go for sync
>> compaction immediately
> 
> IMO, concept of async compaction is also important for non-movable allocation.
> Non-movable allocation is essential for some workload and they hope
> the low latency.

The low latency should not be at the expense of making long-term
fragmentation worse.

> Thanks.
>