linux-kernel - Re: [PATCH] mtd: spi-nor: stm32-quadspi: fix compiler errors with COMPILE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 5 May 2017 09:36:32 +0200
From:   Ludovic BARRE <ludovic.barre@...com>
To:     Cyrille Pitchen <cyrille.pitchen@...ev4u.fr>,
        <marek.vasut@...il.com>, <linux-mtd@...ts.infradead.org>
CC:     <computersforpeace@...il.com>, <dwmw2@...radead.org>,
        <boris.brezillon@...e-electrons.com>, <richard@....at>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] mtd: spi-nor: stm32-quadspi: fix compiler errors with
 COMPILE_TEST


On 05/04/2017 09:39 PM, Cyrille Pitchen wrote:
> This patch fixes some compiler errors:
> - change format strings to use %zx for size_t
> - add missing #include <linux/sizes.h>
>
> Cc: Ludovic Barre <ludovic.barre@...com>
> Signed-off-by: Cyrille Pitchen <cyrille.pitchen@...ev4u.fr>
> ---
>   drivers/mtd/spi-nor/stm32-quadspi.c | 5 +++--
>   1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mtd/spi-nor/stm32-quadspi.c b/drivers/mtd/spi-nor/stm32-quadspi.c
> index 1056e7408d2a..86c0931543c5 100644
> --- a/drivers/mtd/spi-nor/stm32-quadspi.c
> +++ b/drivers/mtd/spi-nor/stm32-quadspi.c
> @@ -19,6 +19,7 @@
>   #include <linux/of_device.h>
>   #include <linux/platform_device.h>
>   #include <linux/reset.h>
> +#include <linux/sizes.h>
>   
>   #define QUADSPI_CR		0x00
>   #define CR_EN			BIT(0)
> @@ -375,7 +376,7 @@ static ssize_t stm32_qspi_read(struct spi_nor *nor, loff_t from, size_t len,
>   	struct stm32_qspi_cmd cmd;
>   	int err;
>   
> -	dev_dbg(qspi->dev, "read(%#.2x): buf:%p from:%#.8x len:%#x\n",
> +	dev_dbg(qspi->dev, "read(%#.2x): buf:%p from:%#.8x len:%#zx\n",
>   		nor->read_opcode, buf, (u32)from, len);
>   
>   	memset(&cmd, 0, sizeof(cmd));
> @@ -402,7 +403,7 @@ static ssize_t stm32_qspi_write(struct spi_nor *nor, loff_t to, size_t len,
>   	struct stm32_qspi_cmd cmd;
>   	int err;
>   
> -	dev_dbg(dev, "write(%#.2x): buf:%p to:%#.8x len:%#x\n",
> +	dev_dbg(dev, "write(%#.2x): buf:%p to:%#.8x len:%#zx\n",
>   		nor->program_opcode, buf, (u32)to, len);
>   
>   	memset(&cmd, 0, sizeof(cmd));
Reviewed-by: Ludovic Barre <ludovic.barre@...com>