linux-kernel - Re: [PATCH v3 2/6] spi: core: Add support for registering SPI slave controllers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 5 May 2017 11:07:31 +0200
From:   Geert Uytterhoeven <geert@...ux-m68k.org>
To:     Geert Uytterhoeven <geert+renesas@...der.be>
Cc:     Mark Brown <broonie@...nel.org>, Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Magnus Damm <magnus.damm@...il.com>,
        Wolfram Sang <wsa+renesas@...g-engineering.com>,
        Hiromitsu Yamasaki <hiromitsu.yamasaki.ym@...esas.com>,
        Jiada Wang <jiada_wang@...tor.com>,
        Matt Porter <mporter@...sulko.com>,
        linux-spi <linux-spi@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        Linux-Renesas <linux-renesas-soc@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Wu Fengguang <fengguang.wu@...el.com>
Subject: Re: [PATCH v3 2/6] spi: core: Add support for registering SPI slave controllers

On Thu, May 4, 2017 at 7:45 PM, Geert Uytterhoeven
<geert+renesas@...der.be> wrote:
> --- a/include/linux/spi/spi.h
> +++ b/include/linux/spi/spi.h

> @@ -447,6 +448,8 @@ struct spi_master {
>  #define SPI_MASTER_MUST_TX      BIT(4)         /* requires tx */
>  #define SPI_MASTER_GPIO_SS      BIT(5)         /* GPIO CS must select slave */
>
> +       bool                    slave;          /* SPI slave controller */

0day reported I forgot to document this new field in kerneldoc, thanks!
Will fix in v4.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds