lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 5 May 2017 15:56:58 +0530 From: Jassi Brar <jassisinghbrar@...il.com> To: Bjorn Andersson <bjorn.andersson@...aro.org> Cc: Andy Gross <andy.gross@...aro.org>, Rob Herring <robh+dt@...nel.org>, Mark Rutland <mark.rutland@....com>, Ohad Ben-Cohen <ohad@...ery.com>, linux-arm-msm@...r.kernel.org, linux-soc@...r.kernel.org, Devicetree List <devicetree@...r.kernel.org>, Linux Kernel Mailing List <linux-kernel@...r.kernel.org>, linux-remoteproc@...r.kernel.org Subject: Re: [PATCH v4 3/5] soc: qcom: Introduce APCS IPC driver On Fri, May 5, 2017 at 1:35 AM, Bjorn Andersson <bjorn.andersson@...aro.org> wrote: > + > +static int qcom_apcs_ipc_send_data(struct mbox_chan *chan, void *data) > +{ > + struct qcom_apcs_ipc *apcs = container_of(chan->mbox, > + struct qcom_apcs_ipc, mbox); > + unsigned long idx = (unsigned long)chan->con_priv; > + > + writel(BIT(idx), apcs->base + apcs->offset); > + When/how does this bit get ever cleared again? You may want to add last_tx_done() callback to check if this bit is cleared before you can send the next interrupt. And set txdone_poll/irq accordingly. Thanks
Powered by blists - more mailing lists