linux-kernel - Re: [PATCH v3] iio: adc: Add support for TI ADC108S102 and ADC128S102

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 5 May 2017 13:40:26 +0300
From:   Mika Westerberg <mika.westerberg@...ux.intel.com>
To:     Jan Kiszka <jan.kiszka@...mens.com>
Cc:     Jonathan Cameron <jic23@...nel.org>, linux-iio@...r.kernel.org,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Sascha Weisenberger <sascha.weisenberger@...mens.com>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Peter Meerwald-Stadler <pmeerw@...erw.net>,
        Rob Herring <robh@...nel.org>
Subject: Re: [PATCH v3] iio: adc: Add support for TI ADC108S102 and ADC128S102

On Fri, May 05, 2017 at 12:23:26PM +0200, Jan Kiszka wrote:
> >> +	} else {
> >> +		st->reg = devm_regulator_get(&spi->dev, "vref");
> >> +		if (IS_ERR(st->reg))
> >> +			return PTR_ERR(st->reg);
> > 
> > This should be an optional regulator and in case of ACPI you just don't
> > have it.
> 
> It's mandatory for this DT case, so I will not change that.

Well, it would be better if you don't need to deviate in the driver like
this. And it clearly is optional because in case of ACPI you don't need
it.

Not my call, though.