linux-kernel - Re: [PATCH/RFC] signal: Export signal_wake_up

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 5 May 2017 13:08:47 +0200
From:   Geert Uytterhoeven <geert@...ux-m68k.org>
To:     Christoph Hellwig <hch@...radead.org>
Cc:     Geert Uytterhoeven <geert+renesas@...der.be>,
        Ingo Molnar <mingo@...nel.org>,
        Peter Zijlstra <peterz@...radead.org>,
        Oleg Nesterov <oleg@...hat.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        linux-spi <linux-spi@...r.kernel.org>
Subject: Re: [PATCH/RFC] signal: Export signal_wake_up_state() to modules

On Fri, May 5, 2017 at 12:13 PM, Geert Uytterhoeven
<geert@...ux-m68k.org> wrote:
> On Fri, May 5, 2017 at 12:07 PM, Christoph Hellwig <hch@...radead.org> wrote:
>> On Fri, May 05, 2017 at 11:49:11AM +0200, Geert Uytterhoeven wrote:
>>> When using signal_wake_up() from a loadable kernel module:
>>>
>>>     ERROR: "signal_wake_up_state" [drivers/spi/spi-sh-msiof.ko] undefined!
>>>
>>> Export signal_wake_up_state() to modules to fix this.
>>
>> Or rever the commit that added the users.  This doesn't look like
>
> That commit is not yet applied.
>
>> functionality a driver should use..
>
> OK.
>
> Then, do you have any advise on how to properly abort a completion?

Of course I can add a flag to indicate abortion, and just call complete_all(),
but IMHO that's a bit silly, given wait_for_completion_interruptible() already
provides this side channel information through -ERESTARTSYS.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds