linux-kernel - Re: [PATCH] drivers: staging/lustre: conrpc.c - fix sparse error: incompatible types in comparison expression (different address spaces)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 5 May 2017 10:53:11 -0300
From:   Tordek <kedrot@...il.com>
To:     Oleg Drokin <oleg.drokin@...el.com>, lustre-devel@...ts.lustre.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drivers: staging/lustre: conrpc.c - fix sparse error:
 incompatible types in comparison expression (different address spaces)

This patch makes a lot of new warnings pop up, because the error is
blocking the rest of the file from being processed.

On 5 May 2017 at 10:51, Guillermo O. Freschi <kedrot@...il.com> wrote:
> Signed-off-by: Guillermo O. Freschi <kedrot@...il.com>
> ---
>  drivers/staging/lustre/lnet/selftest/conrpc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/lustre/lnet/selftest/conrpc.c b/drivers/staging/lustre/lnet/selftest/conrpc.c
> index da36c55b86d3..f4578200994f 100644
> --- a/drivers/staging/lustre/lnet/selftest/conrpc.c
> +++ b/drivers/staging/lustre/lnet/selftest/conrpc.c
> @@ -487,7 +487,7 @@ lstcon_rpc_trans_interpreter(struct lstcon_rpc_trans *trans,
>                                    sizeof(struct list_head)))
>                         return -EFAULT;
>
> -               if (tmp.next == head_up)
> +               if ((struct list_head __user *)tmp.next == head_up)
>                         return 0;
>
>                 next = tmp.next;
> --
> 2.11.0
>