linux-kernel - Re: [PATCH v2 06/16] fpga: region: remove unneeded of_node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 5 May 2017 10:08:11 -0700
From:   Moritz Fischer <mdf@...nel.org>
To:     Alan Tull <atull@...nel.org>
Cc:     Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        linux-fpga@...r.kernel.org
Subject: Re: [PATCH v2 06/16] fpga: region: remove unneeded of_node_get and put

On Thu, Apr 20, 2017 at 7:09 AM, Alan Tull <atull@...nel.org> wrote:
> Remove of_node_get/put in fpga_region_get/put.  Not
> needed and will get in the way when I separate out
> the common FPGA region code from Device Tree support
> code.
>
> Signed-off-by: Alan Tull <atull@...nel.org>

Acked-by: Moritz Fischer <mdf@...nel.org>
> ---
> v2: split out from another patch
> ---
>  drivers/fpga/fpga-region.c | 3 ---
>  1 file changed, 3 deletions(-)
>
> diff --git a/drivers/fpga/fpga-region.c b/drivers/fpga/fpga-region.c
> index eaea9d4..6784357 100644
> --- a/drivers/fpga/fpga-region.c
> +++ b/drivers/fpga/fpga-region.c
> @@ -94,9 +94,7 @@ static struct fpga_region *fpga_region_get(struct fpga_region *region)
>         }
>
>         get_device(dev);
> -       of_node_get(dev->of_node);
>         if (!try_module_get(dev->parent->driver->owner)) {
> -               of_node_put(dev->of_node);
>                 put_device(dev);
>                 mutex_unlock(&region->mutex);
>                 return ERR_PTR(-ENODEV);
> @@ -119,7 +117,6 @@ static void fpga_region_put(struct fpga_region *region)
>         dev_dbg(dev, "put\n");
>
>         module_put(dev->parent->driver->owner);
> -       of_node_put(dev->of_node);
>         put_device(dev);
>         mutex_unlock(&region->mutex);
>  }
> --
> 2.7.4
>