linux-kernel - Re: [PATCH] ima: fix up #endif comments

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 05 May 2017 15:52:58 -0400
From:   Mimi Zohar <zohar@...ux.vnet.ibm.com>
To:     Tycho Andersen <tycho@...ker.com>,
        Dmitry Kasatkin <dmitry.kasatkin@...il.com>
Cc:     linux-ima-devel@...ts.sourceforge.net, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ima: fix up #endif comments

On Fri, 2017-05-05 at 11:15 -0600, Tycho Andersen wrote:
> While reading the code, I noticed that these #endif comments don't match
> how they're actually nested. This patch fixes that.
> 
> Signed-off-by: Tycho Andersen <tycho@...ker.com>

Thanks!

Mimi
> ---
>  security/integrity/ima/ima.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/security/integrity/ima/ima.h b/security/integrity/ima/ima.h
> index b563fbd4d122..d26a30e37d13 100644
> --- a/security/integrity/ima/ima.h
> +++ b/security/integrity/ima/ima.h
> @@ -306,12 +306,12 @@ static inline int security_filter_rule_match(u32 secid, u32 field, u32 op,
>  {
>  	return -EINVAL;
>  }
> -#endif /* CONFIG_IMA_TRUSTED_KEYRING */
> +#endif /* CONFIG_IMA_LSM_RULES */
> 
>  #ifdef	CONFIG_IMA_READ_POLICY
>  #define	POLICY_FILE_FLAGS	(S_IWUSR | S_IRUSR)
>  #else
>  #define	POLICY_FILE_FLAGS	S_IWUSR
> -#endif /* CONFIG_IMA_WRITE_POLICY */
> +#endif /* CONFIG_IMA_READ_POLICY */
> 
>  #endif /* __LINUX_IMA_H */