[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Thu, 4 May 2017 23:20:08 -0700
From: Dan Williams <dan.j.williams@...el.com>
To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc: Linux ACPI <linux-acpi@...r.kernel.org>,
tpmdd-devel@...ts.sourceforge.net, intel-gfx@...ts.freedesktop.org,
nouveau@...ts.freedesktop.org, linux-input@...r.kernel.org,
iommu@...ts.linux-foundation.org, linux-mmc@...r.kernel.org,
Netdev <netdev@...r.kernel.org>, linux-pci@...r.kernel.org,
USB list <linux-usb@...r.kernel.org>,
alsa-devel@...a-project.org,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
"Rafael J . Wysocki" <rjw@...ysocki.net>,
Mika Westerberg <mika.westerberg@...ux.intel.com>,
Borislav Petkov <bp@...e.de>,
Amir Goldstein <amir73il@...il.com>,
Jarkko Sakkinen <jarkko.sakkinen@...ux.intel.com>,
Jani Nikula <jani.nikula@...ux.intel.com>,
Ben Skeggs <bskeggs@...hat.com>,
Benjamin Tissoires <benjamin.tissoires@...hat.com>,
Joerg Roedel <joro@...tes.org>,
Adrian Hunter <adrian.hunter@...el.com>,
Yisen Zhuang <yisen.zhuang@...wei.com>,
Bjorn Helgaas <bhelgaas@...gle.com>,
Zhang Rui <rui.zhang@...el.com>,
Felipe Balbi <balbi@...nel.org>,
Mathias Nyman <mathias.nyman@...el.com>,
Heikki Krogerus <heikki.krogerus@...ux.intel.com>,
Liam Girdwood <lgirdwood@...il.com>,
Mark Brown <broonie@...nel.org>
Subject: Re: [PATCH v1] ACPI: Switch to use generic UUID API
On Thu, May 4, 2017 at 2:21 AM, Andy Shevchenko
<andriy.shevchenko@...ux.intel.com> wrote:
> acpi_evaluate_dsm() and friends take a pointer to a raw buffer of 16
> bytes. Instead we convert them to use uuid_le type. At the same time we
> convert current users.
>
> acpi_str_to_uuid() becomes useless after the conversion and it's safe to
> get rid of it.
>
> The conversion fixes a potential bug in int340x_thermal as well since
> we have to use memcmp() on binary data.
>
> Cc: Rafael J. Wysocki <rjw@...ysocki.net>
> Cc: Mika Westerberg <mika.westerberg@...ux.intel.com>
> Cc: Borislav Petkov <bp@...e.de>
> Cc: Dan Williams <dan.j.williams@...el.com>
> Cc: Amir Goldstein <amir73il@...il.com>
> Cc: Jarkko Sakkinen <jarkko.sakkinen@...ux.intel.com>
> Cc: Jani Nikula <jani.nikula@...ux.intel.com>
> Cc: Ben Skeggs <bskeggs@...hat.com>
> Cc: Benjamin Tissoires <benjamin.tissoires@...hat.com>
> Cc: Joerg Roedel <joro@...tes.org>
> Cc: Adrian Hunter <adrian.hunter@...el.com>
> Cc: Yisen Zhuang <yisen.zhuang@...wei.com>
> Cc: Bjorn Helgaas <bhelgaas@...gle.com>
> Cc: Zhang Rui <rui.zhang@...el.com>
> Cc: Felipe Balbi <balbi@...nel.org>
> Cc: Mathias Nyman <mathias.nyman@...el.com>
> Cc: Heikki Krogerus <heikki.krogerus@...ux.intel.com>
> Cc: Liam Girdwood <lgirdwood@...il.com>
> Cc: Mark Brown <broonie@...nel.org>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
[..]
> diff --git a/drivers/acpi/nfit/core.c b/drivers/acpi/nfit/core.c
> index 0f7982a1caaf..bd3e45ede056 100644
> --- a/drivers/acpi/nfit/core.c
> +++ b/drivers/acpi/nfit/core.c
> @@ -74,11 +74,11 @@ struct nfit_table_prev {
> struct list_head flushes;
> };
>
> -static u8 nfit_uuid[NFIT_UUID_MAX][16];
> +static uuid_le nfit_uuid[NFIT_UUID_MAX];
>
> -const u8 *to_nfit_uuid(enum nfit_uuids id)
> +const uuid_le *to_nfit_uuid(enum nfit_uuids id)
> {
> - return nfit_uuid[id];
> + return &nfit_uuid[id];
> }
> EXPORT_SYMBOL(to_nfit_uuid);
>
> @@ -207,7 +207,7 @@ int acpi_nfit_ctl(struct nvdimm_bus_descriptor *nd_desc, struct nvdimm *nvdimm,
> u32 offset, fw_status = 0;
> acpi_handle handle;
> unsigned int func;
> - const u8 *uuid;
> + const uuid_le *uuid;
> int rc, i;
>
> func = cmd;
> @@ -394,7 +394,7 @@ int nfit_spa_type(struct acpi_nfit_system_address *spa)
> int i;
>
> for (i = 0; i < NFIT_UUID_MAX; i++)
> - if (memcmp(to_nfit_uuid(i), spa->range_guid, 16) == 0)
> + if (!uuid_le_cmp_pp(to_nfit_uuid(i), (uuid_le *)spa->range_guid))
What is _cmp_pp? Why not _compare?
Other than that, looks ok to me.
Powered by blists - more mailing lists